Windows build doesn't support C11 atomics

aws · Sep 4, 2024 · 9255fe2 · 9255fe2
1 parent 9b930c2
commit 9255fe2
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -72,6 +72,13 @@ jobs:
         with:
           toolchain: stable
       - name: Run cargo test
+        # Windows build currently fails when forcing C11:
+        # ```
+        # C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.41.34120\include\vcruntime_c11_stdatomic.h(36,24):
+        #   error C2061: syntax error: identifier 'atomic_bool' [D:\a\aws-lc-rs\aws-lc-rs\target\debug\build\aws-lc-sys-491cb29895f6cb6c\out\build\aws-lc\crypto\crypto_objects.vcxproj]
+        # ```
+        # https://devblogs.microsoft.com/cppblog/c11-atomics-in-visual-studio-2022-version-17-5-preview-2/
+        if: ${{ matrix.c_std != '11' || matrix.os != 'windows-latest' }}
         working-directory: ./aws-lc-rs
         env:
           AWS_LC_SYS_PREBUILT_NASM: 1