-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AES Key Wrap Algorithm Support #250
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
==========================================
+ Coverage 95.21% 95.66% +0.45%
==========================================
Files 55 57 +2
Lines 6980 7751 +771
==========================================
+ Hits 6646 7415 +769
- Misses 334 336 +2 ☔ View full report in Codecov by Sentry. |
651c693
to
421497e
Compare
ca85f4e
to
9dd7466
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. I have a couple of questions we should consider before we finalize this as our "key wrap" API.
c43eba6
to
fe99073
Compare
Description of changes:
Adds
aws_lc_rs::key_wrap
module that provides AES-128 and AES-256 key wrap algorithms (padded and unpadded variants).Testing:
Pulled a partial set of key wrap tests from the available CAVP tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.