Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert -ffile-prefix-map usage w/ CMake #526

Merged
merged 4 commits into from
Sep 18, 2024

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Sep 18, 2024

Problem

  • Consumers using older GCC compilers (< v8.1) with the AWS_LC_SYS_CMAKE_BUILDER=1 environment variable set experience build failures due to GCC lacking support for the -ffile-prefix-map= option.
  • For x86 (32-bit) builds, older GCC compilers do not assume the availability of SSE2. However, SSE2 is required by AWS-LC assembly.

Description of changes:

  • Comment out the use of -ffile-prefix-map= for the CMake builder until we have a better solution.
  • Sets the -msse2 compiler option on x86 builds that use the "cc" builder.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner September 18, 2024 19:43
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.52%. Comparing base (c358484) to head (6709e7c).
Report is 78 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #526      +/-   ##
==========================================
- Coverage   95.80%   92.52%   -3.28%     
==========================================
  Files          61       67       +6     
  Lines        8143     9277    +1134     
  Branches        0     9277    +9277     
==========================================
+ Hits         7801     8584     +783     
- Misses        342      422      +80     
- Partials        0      271     +271     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

samuel40791765
samuel40791765 previously approved these changes Sep 18, 2024
@justsmth justsmth merged commit 27f1692 into aws:main Sep 18, 2024
203 of 213 checks passed
@justsmth justsmth deleted the revert-cmake-ffile-prefix-map branch September 18, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants