Doesn't compile with latest aws-* dependencies with CMAKE updates

[nunotexbsd]

Describe the bug

Hello,

Recently all dependencies of aws-sdk-cpp received cmake changes, like this one: awslabs/aws-c-cal#203
being the last change in: awslabs/aws-crt-cpp#702

Latest release fails with details bellow.

Will a new release be created with CMake changes too?
See also: awslabs/aws-c-cal#204 (comment)

CMake Error at CMakeLists.txt:247 (include):
  include could not find requested file:

    AwsFindPackage


CMake Error at CMakeLists.txt:250 (aws_use_package):
  Unknown CMake command "aws_use_package".


-- Configuring incomplete, errors occurred!

Regression Issue

• Select this option if this issue appears to be a regression.

Expected Behavior

Build with recently cmake updated deps

Current Behavior

doesn't build

Reproduction Steps

FreeBSD framework:

After all deps updated (not committed yet):

cd /usr/ports/devel/aws-sdk-cpp && make

Possible Solution

Update cmake modules and config to match deps updates

Additional Information/Context

No response

AWS CPP SDK version used

1.11.495

Compiler and Version used

Clang 19.1.7

Operating System and version

FreeBSD 15 amd64

[thomas-roos]

Also affected by this with meta-aws Yocto builds.
Like here: https://github.com/aws4embeddedlinux/meta-aws/actions/runs/13065076486/job/36455932376?pr=11366

[nunotexbsd]

@thomas-roos

I have all aws-* in queue waiting for aws-sdk-cpp to get fixed.
I believe that a fix could be done easily by changing cmake to look to new location on deps:

For example, all deps have changed this way:

 include/aws/common/zero.h
 include/aws/common/zero.inl
 include/aws/testing/aws_test_harness.h
-lib/aws-c-common/cmake/aws-c-common-config.cmake
-lib/aws-c-common/cmake/shared/aws-c-common-targets-%%CMAKE_BUILD_TYPE%%.cmake
-lib/aws-c-common/cmake/shared/aws-c-common-targets.cmake
-lib/cmake/AwsCFlags.cmake
-lib/cmake/AwsCRuntime.cmake
-lib/cmake/AwsCheckHeaders.cmake
-lib/cmake/AwsFeatureTests.cmake
-lib/cmake/AwsFindPackage.cmake
-lib/cmake/AwsLibFuzzer.cmake
-lib/cmake/AwsSIMD.cmake
-lib/cmake/AwsSanitizers.cmake
-lib/cmake/AwsSharedLibSetup.cmake
-lib/cmake/AwsTestHarness.cmake
+lib/cmake/aws-c-common/aws-c-common-config.cmake
+lib/cmake/aws-c-common/modules/AwsCFlags.cmake
+lib/cmake/aws-c-common/modules/AwsCRuntime.cmake
+lib/cmake/aws-c-common/modules/AwsCheckHeaders.cmake
+lib/cmake/aws-c-common/modules/AwsFeatureTests.cmake
+lib/cmake/aws-c-common/modules/AwsFindPackage.cmake
+lib/cmake/aws-c-common/modules/AwsLibFuzzer.cmake
+lib/cmake/aws-c-common/modules/AwsSIMD.cmake
+lib/cmake/aws-c-common/modules/AwsSanitizers.cmake
+lib/cmake/aws-c-common/modules/AwsSharedLibSetup.cmake
+lib/cmake/aws-c-common/modules/AwsTestHarness.cmake
+lib/cmake/aws-c-common/shared/aws-c-common-targets-%%CMAKE_BUILD_TYPE%%.cmake
+lib/cmake/aws-c-common/shared/aws-c-common-targets.cmake
 lib/libaws-c-common.so
 lib/libaws-c-common.so.1
 lib/libaws-c-common.so.1.0.0

[nunotexbsd]

It seems that Homebrew already deal with it:
https://github.com/Homebrew/homebrew-core/blob/62ea7c53d2921187ee2f102d2b42bfd41fed54ec/Formula/a/aws-sdk-cpp.rb#L44

[nunotexbsd]

@thomas-roos

I have it building right now by adding args to cmake:

-DCMAKE_MODULE_PATH=${LOCALBASE}/lib/cmake/aws-c-common/modules

$LOCALBASE is /usr/local by default at FreeBSD

[sbiscigl]

yeah we're working on a CRT update, note that the supported version of the aws-c-* dependencies are the ones that we are tracking in submodules and that they did do a minor version bump this time to indicate a breaking change

we are actively looking at it with high priority right now though

I believe that a fix could be done easily by changing cmake to look to new location on deps:

this will likely be the fix, will update when i have it out

[sbiscigl]

merged, should be tagged today, fixed in mainline immediately though, let me know if you see any issues

[github-actions]

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.