fix verify ssl on windows, add option for anonymous auth #3313
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#3008
Description of changes:
We made a previous change to disable TLS when verify ssl was set to false. This was the incorrect behavior, we should try to use TLS but ignore certificate errors. This reverts that behavior changes and adds additional SSL verifications to ignore.
This adds another change that should have been the first fix, which is to allow for anonymous auth which is what the change was initially made to address #1445. the optional as stated by the microsoft docs
This allowed for the basic auth as seen by the original opensearch example
As stated before you likely should not be turning off verify ssl or using basic credentials unless explicitly using a development environment.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.