Enable S3 smithy client #3317
Enable S3 smithy client #3317
Conversation
sbera87
force-pushed
the
s3smithyon
branch
2 times, most recently
from
dea11b7 to
f0684a4
Compare
| @@ -290,18 +460,21 @@ void AwsSmithyClientBase::AttemptOneRequestAsync(std::shared_ptr<AwsSmithyClient | |||
| return; | |||
| } | |||
|
|
|||
| pRequestCtx->m_interceptorContext->SetTransmitRequest(pRequestCtx->m_httpRequest); | |||
| for (const auto& interceptor : m_interceptors) | |||
| if (pRequestCtx->m_interceptorContext) | |||
There was a problem hiding this comment.
just added code block under null guard since in requestless cases, this is currently not created in requestless call flow.
This is done to emulate legacy behavior:
with request case:
vs
request less case:
|
|
||
|
|
||
|
|
||
| void AwsSmithyClientBase::MakeRequestAsyncHelper(std::shared_ptr<AwsSmithyClientAsyncRequestContext>& pRequestCtx, |
There was a problem hiding this comment.
This helper abstracts endpoint resolution into a callback and is invoked contextually by different variations of APIs used for backwards compatibilty
sbera87
force-pushed
the
s3smithyon
branch
3 times, most recently
from
3547603 to
f03166d
Compare
| Aws::Map<Aws::String, Aws::String> params; | ||
| params.emplace("bucketName", bucket); | ||
| ServiceSpecificParameters serviceSpecificParameters{params}; | ||
| auto serviceParams = Aws::MakeShared<ServiceSpecificParameters>(ALLOCATION_TAG, serviceSpecificParameters); | ||
| return AWSClient::GeneratePresignedUrl(endpoint, method, customizedHeaders, expirationInSeconds, Aws::Auth::SIGV4_SIGNER, | ||
| nullptr, nullptr, serviceParams); | ||
| EndpointUpdateCallback endpointCallback = [&](Aws::Endpoint::AWSEndpoint& endpoint){ |
There was a problem hiding this comment.
Changes to resolve endpoint after select auth scheme
| Aws::Vector<AuthSchemeOption> authSchemeOptions = m_authSchemeResolver->resolveAuthScheme(identityParams); | ||
| Aws::Vector<AuthSchemeOption> authSchemeOptions; | ||
| /*for backwards compatibility, signer name override is used to filter auth schemes by id equivalent to legacy signer name*/ | ||
| if(ctx.m_signerNameOverride.has_value()) |
There was a problem hiding this comment.
This is added to make the backwards compatible api functional.
In legacy client, signer name passed was used to fetch the signer object via
auto signer = GetSignerByName(signerName);
In smithy design, this name passed is simply re-mapped and used to filter desired auth scheme (with requested signer) from list of supported auth schemes
| @@ -240,8 +314,141 @@ namespace client | |||
| } | |||
| return GeneratePresignedUrl(uri, method, signerRegionOverride, signerServiceNameOverride, expirationInSeconds, customizedHeaders, serviceSpecificParameters); | |||
| } | |||
|
|
|||
| ResponseT MakeRequest(const Aws::Http::URI& uri, | |||
There was a problem hiding this comment.
Legacy APIs that need to be supported as external clients found to use some variations.
| using ClientError = AWSError; | ||
| using SigningError = AWSError; | ||
| using AWSCoreError = Aws::Client::AWSError<CoreErrors>; | ||
| using ClientError = AWSCoreError; |
There was a problem hiding this comment.
Needed to ensure backwards compatibility . External clients use AwsError as a templated type
| std::shared_ptr<Aws::Utils::Threading::Executor> pExecutor | ||
| ) const; | ||
|
|
||
| const std::shared_ptr<Aws::Client::AWSErrorMarshaller>& GetErrorMarshaller() const |
There was a problem hiding this comment.
Needed as External Users use this
| @@ -200,7 +237,7 @@ namespace client | |||
| Aws::Vector<std::shared_ptr<smithy::interceptor::Interceptor>> m_interceptors{}; | |||
| std::shared_ptr<smithy::client::UserAgentInterceptor> m_userAgentInterceptor; | |||
| private: | |||
| void UpdateAuthSchemeFromEndpoint(const Aws::Endpoint::AWSEndpoint& endpoint, AuthSchemeOption& authscheme) const; | |||
| void UpdateAuthSchemeFromEndpoint(std::shared_ptr<AwsSmithyClientAsyncRequestContext>& pRequestCtx) const; | |||
There was a problem hiding this comment.
Interface updated to facilitate legacy API usage where endpoint may not be available
Issue #, if available:
Description of changes:
This set of changes enables Smithy client for S3 with applicable backwards compatible changes.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.