Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate code gen to use protocol list #3320

Merged
merged 1 commit into from
Mar 1, 2025
Merged

Conversation

sbiscigl
Copy link
Contributor

Description of changes:

Migrate code generation to use protocol list instead of single protocol value. i.e. from s3

  "metadata":{
    "apiVersion":"2006-03-01",
    "checksumFormat":"md5",
    "endpointPrefix":"s3",
    "globalEndpoint":"s3.amazonaws.com",
    "protocol":"rest-xml",
    "protocols":["rest-xml"],
    "serviceAbbreviation":"Amazon S3",
    "serviceFullName":"Amazon Simple Storage Service",
    "serviceId":"S3",
    "signatureVersion":"s3",
    "uid":"s3-2006-03-01",
    "auth":["aws.auth#sigv4"]
  },

This will allow for services to support different protocols, for now we will just select the first protocol that is not CBOR as we do not support it yet.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbiscigl sbiscigl force-pushed the protocol-list-migration branch from e9cf7a4 to 9e92ed3 Compare February 28, 2025 18:14
@sbiscigl sbiscigl force-pushed the protocol-list-migration branch 3 times, most recently from 8dab574 to e94ced0 Compare February 28, 2025 19:22
@sbiscigl sbiscigl force-pushed the protocol-list-migration branch from e94ced0 to aa83789 Compare February 28, 2025 20:51
@sbiscigl sbiscigl marked this pull request as ready for review February 28, 2025 21:17
@sbiscigl sbiscigl merged commit ac840d1 into main Mar 1, 2025
4 checks passed
@sbiscigl sbiscigl deleted the protocol-list-migration branch March 1, 2025 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants