Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to the DefaultAWSCredentialsIdentityResolver #3617

Merged
merged 2 commits into from
Jan 22, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -41,27 +41,41 @@ public class DefaultAWSCredentialsIdentityResolver : IIdentityResolver<AWSCreden
private readonly CredentialProfileStoreChain _credentialProfileChain = new();
private readonly EnvironmentState _lastKnownEnvironmentState = new();

private static readonly Lazy<DefaultAWSCredentialsIdentityResolver> _defaultInstance = new Lazy<DefaultAWSCredentialsIdentityResolver>();

public DefaultAWSCredentialsIdentityResolver()
{
try
_cachedCredentials = null;
_credentialsGenerators = new List<CredentialsGenerator>
{
_cachedCredentialsLock.EnterWriteLock();
_cachedCredentials = null;
_credentialsGenerators = new List<CredentialsGenerator>
{
#if BCL
() => new AppConfigAWSCredentials(), // Test explicit keys/profile name first.
() => new AppConfigAWSCredentials(), // Test explicit keys/profile name first.
#endif
() => new EnvironmentVariablesAWSCredentials(), // Look for credentials set in environment vars.
() => AssumeRoleWithWebIdentityCredentials.FromEnvironmentVariables(),
() => GetAWSCredentials(_credentialProfileChain),
() => ContainerEC2CredentialsWrapper(), // either get ECS / EKS credentials or instance profile credentials
};
}
finally
{
_cachedCredentialsLock.ExitWriteLock();
}
() => new EnvironmentVariablesAWSCredentials(), // Look for credentials set in environment vars.
() => AssumeRoleWithWebIdentityCredentials.FromEnvironmentVariables(),
() => GetAWSCredentials(_credentialProfileChain),
() => ContainerEC2CredentialsWrapper(), // either get ECS / EKS credentials or instance profile credentials
};
}

/// <summary>
/// Search the environment for configured AWS credentials. The search includes
/// environment variables, "default" AWS credentials profiles and EC2 instance metadata.
/// </summary>
/// <returns>AWSCredentials that can be used when creating AWS service clients.</returns>
public static AWSCredentials GetCredentials()
{
return _defaultInstance.Value.ResolveIdentity();
}

/// <summary>
/// Search the environment for configured AWS credentials. The search includes
/// environment variables, "default" AWS credentials profiles and EC2 instance metadata.
/// </summary>
/// <returns>AWSCredentials that can be used when creating AWS service clients.</returns>
public static Task<AWSCredentials> GetCredentialsAsync()
{
return _defaultInstance.Value.ResolveIdentityAsync();
}

BaseIdentity IIdentityResolver.ResolveIdentity()
Expand Down
Loading