fix imds mocking and update cases in nodeadm e2e tests #1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndbaker1
force-pushed
the
fix-nodeadm-e2e
branch
7 times, most recently
from
eea92b0 to
1e0cadb
Compare
ndbaker1
changed the title
ndbaker1
force-pushed
the
fix-nodeadm-e2e
branch
2 times, most recently
from
8da9d96 to
b422775
Compare
ndbaker1
force-pushed
the
fix-nodeadm-e2e
branch
from
b422775 to
4cba0f1
Compare
|
the 2nd test case is an actual issue to fix in another PR 😉 |
cartermckinnon
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Testing Done