Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nodeadm usage, config example #1584

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Add nodeadm usage, config example #1584

merged 2 commits into from
Jan 18, 2024

Conversation

cartermckinnon
Copy link
Member

Description of changes:

Adds some more detail to the README, to aid in discussion with other projects in this AMI's orbit.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.


---
apiVersion: node.eks.aws/v1alpha1
kind: NodeConfig
Copy link
Contributor

@bryantbiggs bryantbiggs Jan 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does this interface with managed nodegroups - are the details to join to the cluster contained in this same config, can multiple configs be provided and merged, etc?

Mainly - will this get around the current issues with managed nodegroups today #844 - where the injected bootstrap script invocation leaves users to find hacky ways to pass in values supported by the bootstrap script

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're talking about passing this config object in a custom launch template, without specifying an AMI in the LT, right? i.e. a "custom LT" nodegroup instead of a "custom AMI" nodegroup?

We have the ability to implement that with this approach, yes; because managed nodegroups can add the important bits as necessary, instead of only tacking on a MIME part.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i.e. a "custom LT" nodegroup instead of a "custom AMI" nodegroup?

Correct

The most basic, contrived example would be a managed nodegroup using the AL2_x86_64 AMI type (EKS AMI, not custom AMI), and the user provides a custom launch template where they want to somehow do the equivalent of --local-disks raid0. Today this is a bit of a challenge since MNGs will append the bootstrap script in the last MIME doc, so you have to find various hacky ways for that invocation to pick up this config. So with either Karpenter or MNG, if there was a way to do something where users can pass in a config that does not conflict with the node joining the cluster logic, that would be ideal. something that is probably merged in with whatever defaults you all set

Co-authored-by: Nick Baker <ndbaker1@outlook.com>
@cartermckinnon cartermckinnon merged commit ff4d2ca into al2023 Jan 18, 2024
5 of 6 checks passed
@cartermckinnon cartermckinnon deleted the nodeadm-readme branch January 18, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants