Name node with Instance Id for AL2023 AMI #1589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndbaker1
reviewed
Jan 22, 2024
nodeadm/internal/kubelet/config.go
Outdated
Comment on lines
207
to
208
| // --container-runtime-endpoint moved to kubelet config start from 1.27 | ||
| kubeletArguments["container-runtime-endpoint"] = "unix:///run/containerd/containerd.sock" |
There was a problem hiding this comment.
wow i didn't think to check that, nice catch
There was a problem hiding this comment.
lemme update this into the comment!
ndbaker1
approved these changes
Jan 22, 2024
| if semver.Compare(kubeletVersion, "v1.27.0") < 0 { | ||
| // --container-runtime flag is gone in 1.27+ |
There was a problem hiding this comment.
Can we have this logic for all the versions and remove this configuration from kubelet-containerd.service file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Name AL2023 Nodes using Instance Id
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Testing Done
Build AL2023 1.23 and 1.28 AMI and tested with kubetest2
Example output for 1.23 test
See this guide for recommended testing for PRs. Some tests may not apply. Completing tests and providing additional validation steps are not required, but it is recommended and may reduce review time and time to merge.