Add ENA driver version in version info file #2171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Get ENA driver version | ||
| network_interface=$(sudo ip link show | awk -F': ' '$2 ~ /^eth|^ens/ {print $2}' | head -n1) | ||
| ena_version=$(sudo ethtool -i $network_interface | awk '/version:/ {print $2}') | ||
| echo "$packages" | jq --arg ena_version "$ena_version" '.packages["ena"] = $ena_version' > $OUTPUT_FILE |
There was a problem hiding this comment.
We should reserve the packages section for things actually installed by the package manager. Let's create a new section for kernel modules if we want to add ena.
You can also grab the version of the kmod more easily with modinfo ena.
There was a problem hiding this comment.
It is much easier! Using modinfo to get ena driver version and also create a kernel_modules section in version info file.
The output will looks like
{ "packages": { ... }, "kernel_modules": { "ena": "2.13.2g" }, "binaries": { "kubelet": "v1.31.5-eks-5d632ec", "awscli": "2.24.17" } }
Issacwww
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
modinfo ena, createkernel_modulessection in version info fileTesting Done
Version info file generated for AL2023 and AL2