feat(nodeadm): enable CDI for 1.32+ #2173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermckinnon
commented
Mar 5, 2025
Comment on lines
+152
to
+158
| log.Info("Fetching kubelet version..") | ||
| kubeletVersion, err := kubelet.GetKubeletVersion() | ||
| if err != nil { | ||
| return err | ||
| } | ||
| cfg.Status.KubeletVersion = kubeletVersion | ||
| log.Info("Fetched kubelet version", zap.String("version", kubeletVersion)) |
There was a problem hiding this comment.
We were calling kubelet.GetKubeletVersion() in several places, and they all had access to the NodeConfig, so I just cached it in the NodeConfigStatus.
cartermckinnon
force-pushed
the
enable-cdi-132
branch
from
bbd6d3c to
bcf3221
Compare
cartermckinnon
force-pushed
the
enable-cdi-132
branch
from
bcf3221 to
21d670a
Compare
|
/ci |
|
@cartermckinnon roger that! I've dispatched a workflow. 👍 |
ndbaker1
approved these changes
Mar 6, 2025
|
@cartermckinnon the workflow that you requested has completed. 🎉
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Continues #2100.
This sets
enable_cdi = truein thecontainerdconfiguration for Kubernetes version 1.32 and later. This is in preparation (anticipation?) for Dyanmic Resource Allocation (DRA) becoming enabled by default in 1.33.I have not set this option in AL2, because 1.33 will not be supported on AL2.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.