Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verifying versioned libs #1116

Merged
merged 14 commits into from
Dec 6, 2023
Merged

Verifying versioned libs #1116

merged 14 commits into from
Dec 6, 2023

Conversation

jdelapla
Copy link
Contributor

@jdelapla jdelapla commented Dec 5, 2023

Issue #, if available:
#723

Description of changes:
Versioning libraries

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

spotrh and others added 11 commits July 6, 2021 16:58
.. is required for fetching files from parent dir ... without .. it throws error
Co-authored-by: David D <david.desbiens@tentaq.com>
* Fix typo in readme

* Update Readme

Debug section: add solution to cmake error "could not find JNI"

Co-authored-by: Hassan Sahibzada <hsahibza@amazon.com>
Co-authored-by: Hassan Sahibzada <hsahibza@amazon.com>
Co-authored-by: Hassan Sahibzada <hsahibza@amazon.com>
Hoping this help others avoid hours of frustration.

As noted in the helpful but well hidden issue comment #193 (comment), the Gstreamer examples for RTSP do not run at all.  I'm no Gstreamer expert but using `h264parse` works perfectly, while `video/x-h264, format=avc,alignment=au` just causes the pipeline to hang.
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@sirknightj
Copy link
Contributor

I also updated the property set for the user agent to use this new value

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (22f365e) 16.34% compared to head (96990d8) 16.39%.

❗ Current head 96990d8 differs from pull request most recent head 0d22804. Consider uploading reports for the commit 0d22804 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1116      +/-   ##
===========================================
+ Coverage    16.34%   16.39%   +0.05%     
===========================================
  Files           51       51              
  Lines         6846     6849       +3     
===========================================
+ Hits          1119     1123       +4     
+ Misses        5727     5726       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdelapla jdelapla merged commit 9f28a4c into develop Dec 6, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants