Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install some files #721

Closed
wants to merge 1 commit into from
Closed

install some files #721

wants to merge 1 commit into from

Conversation

spotaws
Copy link

@spotaws spotaws commented Jul 6, 2021

Issue #, if available:

Description of changes:
So, um, cmake does not actually install anything right now. I understand that this code is in active development, but still... This change installs the binaries, the gstreamer plugin, and the JNI header files into what I think are correct targets. There are other header files in the tree that probably need to be installed, but I wasn't sure where they would go.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jdelapla jdelapla self-requested a review August 3, 2021 19:00
niyatim23
niyatim23 reviewed Dec 6, 2023
View reviewed changes
Copy link
Contributor

@niyatim23 niyatim23 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed that #1087 covers a part of this. Not sure if we want to install JNI and our samples as well

@niyatim23 niyatim23 requested a review from disa6302 December 6, 2023 00:22
@niyatim23 niyatim23 mentioned this pull request Dec 6, 2023
Merged
niyatim23
niyatim23 reviewed Dec 6, 2023
View reviewed changes
Copy link
Contributor

@niyatim23 niyatim23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing in favor of #1118. Thanks for your contribution!

@niyatim23 niyatim23 closed this Dec 6, 2023
disa6302 pushed a commit that referenced this pull request Dec 6, 2023
@niyatim23 @spotrh
[PR #721] Install some files (#1118)
86d1ef7 
* install some files

* cleanup

---------

Co-authored-by: Tom spot Callaway <spot@fedoraproject.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niyatim23 niyatim23 niyatim23 left review comments

@jdelapla jdelapla Awaiting requested review from jdelapla

@disa6302 disa6302 Awaiting requested review from disa6302

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spotaws @niyatim23 @spotrh