Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(proxy): add httpProxy and httpsProxy in the options of the addProxyToClient function #34

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

fossamagna
Copy link
Contributor

Description of change

Fixes #33

Pull-Request Checklist

  • Code is up-to-date with the main branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions outlined in the conventional commit spec

@fossamagna
Copy link
Contributor Author

@ryansonshine
Could you approval to run workflows?

@ryansonshine
Copy link
Contributor

Hi @fossamagna , I'm no longer at AWS and do not have permissions to run workflows or merge. @smguggen , can you take a look at this?

@smguggen smguggen merged commit 58b719b into awslabs:main Jul 24, 2024
3 checks passed
Copy link

🎉 This PR is included in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add httpProxy and httpsProxy in the options of the addProxyToClient function
3 participants