-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/replace-rdd #586
Merged
Merged
feature/replace-rdd #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mentekid
approved these changes
Oct 1, 2024
eycho-am
pushed a commit
to eycho-am/deequ
that referenced
this pull request
Oct 9, 2024
Co-authored-by: Shriya Vanvari <svanvari@amazon.com>
eycho-am
pushed a commit
to eycho-am/deequ
that referenced
this pull request
Oct 9, 2024
Co-authored-by: Shriya Vanvari <svanvari@amazon.com>
eycho-am
pushed a commit
to eycho-am/deequ
that referenced
this pull request
Oct 9, 2024
Co-authored-by: Shriya Vanvari <svanvari@amazon.com>
eycho-am
pushed a commit
to eycho-am/deequ
that referenced
this pull request
Oct 9, 2024
Co-authored-by: Shriya Vanvari <svanvari@amazon.com>
mentekid
added a commit
that referenced
this pull request
Oct 9, 2024
* Replace 'withColumns' with 'select' (#582) 'withColumns' was introduced in Spark 3.3, so it won't work for Deequ's <3.3 builds. * Replace rdd with dataframe functions in Histogram analyzer (#586) Co-authored-by: Shriya Vanvari <svanvari@amazon.com> * Updated version in pom.xml to 2.0.8-spark-3.5 (#578) Co-authored-by: Yannis Mentekidis <mentekid@amazon.com> --------- Co-authored-by: Josh <5685731+marcantony@users.noreply.github.com> Co-authored-by: Shriya Vanvari <vanvari.shriya@gmail.com> Co-authored-by: Shriya Vanvari <svanvari@amazon.com> Co-authored-by: Yannis Mentekidis <mentekid@users.noreply.github.com> Co-authored-by: Yannis Mentekidis <mentekid@amazon.com>
mentekid
pushed a commit
that referenced
this pull request
Oct 9, 2024
* Configurable RetainCompletenessRule (#564) * Configurable RetainCompletenessRule * Add doc string * Add default completeness const * Optional specification of instance name in CustomSQL analyzer metric. (#569) Co-authored-by: Tyler Mcdaniel <tymcd@amazon.com> * Adding Wilson Score Confidence Interval Strategy (#567) * Configurable RetainCompletenessRule * Add doc string * Add default completeness const * Add ConfidenceIntervalStrategy * Add Separate Wilson and Wald Interval Test * Add License information, Fix formatting * Add License information * formatting fix * Update documentation * Make WaldInterval the default strategy for now * Formatting import to per line * Separate group import to per line import * CustomAggregator (#572) * Add support for EntityTypes dqdl rule * Add support for Conditional Aggregation Analyzer --------- Co-authored-by: Joshua Zexter <jzexter@amazon.com> * fix typo (#574) * Fix performance of building row-level results (#577) * Generate row-level results with withColumns Iteratively using withColumn (singular) causes performance issues when iterating over a large sequence of columns. * Add back UNIQUENESS_ID * Replace 'withColumns' with 'select' (#582) 'withColumns' was introduced in Spark 3.3, so it won't work for Deequ's <3.3 builds. * Replace rdd with dataframe functions in Histogram analyzer (#586) Co-authored-by: Shriya Vanvari <svanvari@amazon.com> * Updated version in pom.xml to 2.0.8-spark-3.4 --------- Co-authored-by: zeotuan <48720253+zeotuan@users.noreply.github.com> Co-authored-by: tylermcdaniel0 <144386264+tylermcdaniel0@users.noreply.github.com> Co-authored-by: Tyler Mcdaniel <tymcd@amazon.com> Co-authored-by: Joshua Zexter <67130377+joshuazexter@users.noreply.github.com> Co-authored-by: Joshua Zexter <jzexter@amazon.com> Co-authored-by: bojackli <478378663@qq.com> Co-authored-by: Josh <5685731+marcantony@users.noreply.github.com> Co-authored-by: Shriya Vanvari <vanvari.shriya@gmail.com> Co-authored-by: Shriya Vanvari <svanvari@amazon.com>
mentekid
pushed a commit
that referenced
this pull request
Oct 9, 2024
* Configurable RetainCompletenessRule (#564) * Configurable RetainCompletenessRule * Add doc string * Add default completeness const * Optional specification of instance name in CustomSQL analyzer metric. (#569) Co-authored-by: Tyler Mcdaniel <tymcd@amazon.com> * Adding Wilson Score Confidence Interval Strategy (#567) * Configurable RetainCompletenessRule * Add doc string * Add default completeness const * Add ConfidenceIntervalStrategy * Add Separate Wilson and Wald Interval Test * Add License information, Fix formatting * Add License information * formatting fix * Update documentation * Make WaldInterval the default strategy for now * Formatting import to per line * Separate group import to per line import * CustomAggregator (#572) * Add support for EntityTypes dqdl rule * Add support for Conditional Aggregation Analyzer --------- Co-authored-by: Joshua Zexter <jzexter@amazon.com> * fix typo (#574) * Fix performance of building row-level results (#577) * Generate row-level results with withColumns Iteratively using withColumn (singular) causes performance issues when iterating over a large sequence of columns. * Add back UNIQUENESS_ID * Replace 'withColumns' with 'select' (#582) 'withColumns' was introduced in Spark 3.3, so it won't work for Deequ's <3.3 builds. * Replace rdd with dataframe functions in Histogram analyzer (#586) Co-authored-by: Shriya Vanvari <svanvari@amazon.com> * Match Breeze version with spark 3.3 (#562) * Updated version in pom.xml to 2.0.8-spark-3.3 --------- Co-authored-by: zeotuan <48720253+zeotuan@users.noreply.github.com> Co-authored-by: tylermcdaniel0 <144386264+tylermcdaniel0@users.noreply.github.com> Co-authored-by: Tyler Mcdaniel <tymcd@amazon.com> Co-authored-by: Joshua Zexter <67130377+joshuazexter@users.noreply.github.com> Co-authored-by: Joshua Zexter <jzexter@amazon.com> Co-authored-by: bojackli <478378663@qq.com> Co-authored-by: Josh <5685731+marcantony@users.noreply.github.com> Co-authored-by: Shriya Vanvari <vanvari.shriya@gmail.com> Co-authored-by: Shriya Vanvari <svanvari@amazon.com>
mentekid
pushed a commit
that referenced
this pull request
Oct 9, 2024
* Configurable RetainCompletenessRule (#564) * Configurable RetainCompletenessRule * Add doc string * Add default completeness const * Optional specification of instance name in CustomSQL analyzer metric. (#569) Co-authored-by: Tyler Mcdaniel <tymcd@amazon.com> * Adding Wilson Score Confidence Interval Strategy (#567) * Configurable RetainCompletenessRule * Add doc string * Add default completeness const * Add ConfidenceIntervalStrategy * Add Separate Wilson and Wald Interval Test * Add License information, Fix formatting * Add License information * formatting fix * Update documentation * Make WaldInterval the default strategy for now * Formatting import to per line * Separate group import to per line import * CustomAggregator (#572) * Add support for EntityTypes dqdl rule * Add support for Conditional Aggregation Analyzer --------- Co-authored-by: Joshua Zexter <jzexter@amazon.com> * fix typo (#574) * Fix performance of building row-level results (#577) * Generate row-level results with withColumns Iteratively using withColumn (singular) causes performance issues when iterating over a large sequence of columns. * Add back UNIQUENESS_ID * Replace 'withColumns' with 'select' (#582) 'withColumns' was introduced in Spark 3.3, so it won't work for Deequ's <3.3 builds. * Replace rdd with dataframe functions in Histogram analyzer (#586) Co-authored-by: Shriya Vanvari <svanvari@amazon.com> * Updated version in pom.xml to 2.0.8-spark-3.2 --------- Co-authored-by: zeotuan <48720253+zeotuan@users.noreply.github.com> Co-authored-by: tylermcdaniel0 <144386264+tylermcdaniel0@users.noreply.github.com> Co-authored-by: Tyler Mcdaniel <tymcd@amazon.com> Co-authored-by: Joshua Zexter <67130377+joshuazexter@users.noreply.github.com> Co-authored-by: Joshua Zexter <jzexter@amazon.com> Co-authored-by: bojackli <478378663@qq.com> Co-authored-by: Josh <5685731+marcantony@users.noreply.github.com> Co-authored-by: Shriya Vanvari <vanvari.shriya@gmail.com> Co-authored-by: Shriya Vanvari <svanvari@amazon.com>
mentekid
pushed a commit
that referenced
this pull request
Oct 9, 2024
* Configurable RetainCompletenessRule (#564) * Configurable RetainCompletenessRule * Add doc string * Add default completeness const * Optional specification of instance name in CustomSQL analyzer metric. (#569) Co-authored-by: Tyler Mcdaniel <tymcd@amazon.com> * Adding Wilson Score Confidence Interval Strategy (#567) * Configurable RetainCompletenessRule * Add doc string * Add default completeness const * Add ConfidenceIntervalStrategy * Add Separate Wilson and Wald Interval Test * Add License information, Fix formatting * Add License information * formatting fix * Update documentation * Make WaldInterval the default strategy for now * Formatting import to per line * Separate group import to per line import * CustomAggregator (#572) * Add support for EntityTypes dqdl rule * Add support for Conditional Aggregation Analyzer --------- Co-authored-by: Joshua Zexter <jzexter@amazon.com> * fix typo (#574) * Fix performance of building row-level results (#577) * Generate row-level results with withColumns Iteratively using withColumn (singular) causes performance issues when iterating over a large sequence of columns. * Add back UNIQUENESS_ID * Replace 'withColumns' with 'select' (#582) 'withColumns' was introduced in Spark 3.3, so it won't work for Deequ's <3.3 builds. * Replace rdd with dataframe functions in Histogram analyzer (#586) Co-authored-by: Shriya Vanvari <svanvari@amazon.com> * pdated version in pom.xml to 2.0.8-spark-3.1 --------- Co-authored-by: zeotuan <48720253+zeotuan@users.noreply.github.com> Co-authored-by: tylermcdaniel0 <144386264+tylermcdaniel0@users.noreply.github.com> Co-authored-by: Tyler Mcdaniel <tymcd@amazon.com> Co-authored-by: Joshua Zexter <67130377+joshuazexter@users.noreply.github.com> Co-authored-by: Joshua Zexter <jzexter@amazon.com> Co-authored-by: bojackli <478378663@qq.com> Co-authored-by: Josh <5685731+marcantony@users.noreply.github.com> Co-authored-by: Shriya Vanvari <vanvari.shriya@gmail.com> Co-authored-by: Shriya Vanvari <svanvari@amazon.com>
rdsharma26
pushed a commit
that referenced
this pull request
Dec 18, 2024
Co-authored-by: Shriya Vanvari <svanvari@amazon.com>
eycho-am
pushed a commit
that referenced
this pull request
Jan 16, 2025
Co-authored-by: Shriya Vanvari <svanvari@amazon.com>
SamPom100
pushed a commit
that referenced
this pull request
Jan 16, 2025
Co-authored-by: Shriya Vanvari <svanvari@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The refactoring replaces the usage of RDDs with DataFrame operations in the HistogramAnalyzer to leverage DataFrame APIs for more efficient processing.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.