fix: repo info for Gitlab does not support group nesting #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faymard
commented
Jan 8, 2025
faymard
commented
Jan 8, 2025
faymard
force-pushed
the
fix-repo-info
branch
from
4de9f35 to
2f48d4e
Compare
faymard
force-pushed
the
fix-repo-info
branch
from
2f48d4e to
0fa98a1
Compare
|
@faymard - thanks for this contribution. We appreciate it. We will review it and test it before our next release. |
fjudith
pushed a commit
to alithya-oss/backstage-plugins
that referenced
this pull request
Feb 3, 2025
5 tasks
fjudith
added a commit
to alithya-oss/backstage-plugins
that referenced
this pull request
Feb 3, 2025
awslabs/harmonix#140 Co-authored-by: Florian JUDITH <florian.judith@alithya.com>
fjudith
added a commit
to alithya-oss/backstage-plugins
that referenced
this pull request
Feb 4, 2025
* Fixed repo info for Gitlab does not support group nesting awslabs/harmonix#140 * Bump Backstage framework version 1.35.1 * Updated api reports * Fixed alpha endpoints * Fixed lockfile duplicates --------- Co-authored-by: Florian JUDITH <florian.judith@alithya.com>
|
I am bumping into the exact same issue. |
|
We do not have a hard date at this time for the next Harmonix release. We have internal discussions going on with regard to this. In the mean time, I suggest going forward with your own repo fork. Thanks a lot for the feedback and contributions. They mean a lot to our team! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.
git-util.tsto support hosting Harmonix reference repositories in a nested Gitlab groupGitlabApi::getFileContents(parse base 64) andGitlabApi::commitContent(redundant json() call)Motivation
We are working on integrating Harmonix in an existing Backstage and GitLab environment. Everything went surprisingly fine with installing/integrating the plugins and hosting Harmonix templates, but we are encountering an issue when deleting resources from Backstage.
It seems that it comes from the way repository name and group are computed. This PR aims to correct it to support different nesting levels in GitLab.
GitHub is not impacted because deep nesting is not possible (it is always organization/repo) but I thought it would be better to unify how these informations are queried.
For Moderators
Additional Notes