Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(constructs): service linked role missing permissions #631

Closed
wants to merge 4 commits into from
Closed

fix(constructs): service linked role missing permissions #631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
130b44a
fix(constructs): service linked role missing permissions
richardkeit Nov 4, 2024
023041d
update snapshots
richardkeit Nov 4, 2024
a48c639
release/v1.10.1
rycerrat Nov 19, 2024
9286f99
updated merge
richardkeit Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions source/packages/@aws-accelerator/accelerator/test/__snapshots__/accounts-stack.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,7 @@ exports[`AccountsStack us-east-1 Construct(AccountsStack): Snapshot Test 1`] =
"Action": [
"iam:CreateServiceLinkedRole",
"iam:GetRole",
"lambda:GetFunction",
],
"Effect": "Allow",
"Resource": "*",
Expand Down Expand Up @@ -1196,6 +1197,7 @@ exports[`AccountsStack us-east-1 Construct(AccountsStack): Snapshot Test 1`] =
"Action": [
"iam:CreateServiceLinkedRole",
"iam:GetRole",
"lambda:GetFunction",
],
"Effect": "Allow",
"Resource": "*",
Expand Down Expand Up @@ -1466,6 +1468,7 @@ exports[`AccountsStack us-east-1 Construct(AccountsStack): Snapshot Test 1`] =
"Action": [
"iam:CreateServiceLinkedRole",
"iam:GetRole",
"lambda:GetFunction",
],
"Effect": "Allow",
"Resource": "*",
Expand Down Expand Up @@ -2727,6 +2730,7 @@ exports[`AccountsStack us-east-1 Construct(AccountsStack): Snapshot Test 1`] =
"Action": [
"iam:CreateServiceLinkedRole",
"iam:GetRole",
"lambda:GetFunction",
],
"Effect": "Allow",
"Resource": "*",
Expand Down
6 changes: 6 additions & 0 deletions source/packages/@aws-accelerator/accelerator/test/__snapshots__/logging-stack.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ exports[`LoggingStack Construct(LoggingStack): Snapshot Test 1`] = `
"Action": [
"iam:CreateServiceLinkedRole",
"iam:GetRole",
"lambda:GetFunction",
],
"Effect": "Allow",
"Resource": "*",
Expand Down Expand Up @@ -1667,6 +1668,7 @@ exports[`LoggingStack Construct(LoggingStack): Snapshot Test 1`] = `
"Action": [
"iam:CreateServiceLinkedRole",
"iam:GetRole",
"lambda:GetFunction",
],
"Effect": "Allow",
"Resource": "*",
Expand Down Expand Up @@ -4773,6 +4775,7 @@ exports[`LoggingStack Construct(LoggingStack): Snapshot Test 2`] = `
"Action": [
"iam:CreateServiceLinkedRole",
"iam:GetRole",
"lambda:GetFunction",
],
"Effect": "Allow",
"Resource": "*",
Expand Down Expand Up @@ -5305,6 +5308,7 @@ exports[`LoggingStack Construct(LoggingStack): Snapshot Test 2`] = `
"Action": [
"iam:CreateServiceLinkedRole",
"iam:GetRole",
"lambda:GetFunction",
],
"Effect": "Allow",
"Resource": "*",
Expand Down Expand Up @@ -9491,6 +9495,7 @@ exports[`LoggingStackOuTargets Construct(LoggingStackOuTargets): Snapshot Test
"Action": [
"iam:CreateServiceLinkedRole",
"iam:GetRole",
"lambda:GetFunction",
],
"Effect": "Allow",
"Resource": "*",
Expand Down Expand Up @@ -10765,6 +10770,7 @@ exports[`LoggingStackOuTargets Construct(LoggingStackOuTargets): Snapshot Test
"Action": [
"iam:CreateServiceLinkedRole",
"iam:GetRole",
"lambda:GetFunction",
],
"Effect": "Allow",
"Resource": "*",
Expand Down
1 change: 1 addition & 0 deletions ...s-accelerator/accelerator/test/__snapshots__/network-associations-gwlb-stack.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2065,6 +2065,7 @@ exports[`NetworkAssociationsGwlbStack Construct(NetworkAssociationsGwlbStack):
"Action": [
"iam:CreateServiceLinkedRole",
"iam:GetRole",
"lambda:GetFunction",
],
"Effect": "Allow",
"Resource": "*",
Expand Down
3 changes: 3 additions & 0 deletions ...packages/@aws-accelerator/accelerator/test/__snapshots__/organizations-stack.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2328,6 +2328,7 @@ exports[`MultiOuOrganizationsStack Construct(OrganizationsStack): Snapshot Test
"Action": [
"iam:CreateServiceLinkedRole",
"iam:GetRole",
"lambda:GetFunction",
],
"Effect": "Allow",
"Resource": "*",
Expand Down Expand Up @@ -5752,6 +5753,7 @@ exports[`OrganizationsStack Construct(OrganizationsStack): Snapshot Test 1`] =
"Action": [
"iam:CreateServiceLinkedRole",
"iam:GetRole",
"lambda:GetFunction",
],
"Effect": "Allow",
"Resource": "*",
Expand Down Expand Up @@ -9069,6 +9071,7 @@ exports[`delegatedAdminStack Construct(OrganizationsStack): Snapshot Test 1`] =
"Action": [
"iam:CreateServiceLinkedRole",
"iam:GetRole",
"lambda:GetFunction",
],
"Effect": "Allow",
"Resource": "*",
Expand Down
1 change: 1 addition & 0 deletions source/packages/@aws-accelerator/accelerator/test/__snapshots__/pipeline-stack.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1563,6 +1563,7 @@ exports[`PipelineStack Construct(PipelineStack): Snapshot Test 1`] = `
"Action": [
"iam:CreateServiceLinkedRole",
"iam:GetRole",
"lambda:GetFunction",
],
"Effect": "Allow",
"Resource": "*",
Expand Down
2 changes: 1 addition & 1 deletion source/packages/@aws-accelerator/constructs/lib/aws-iam/service-linked-role.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export class ServiceLinkedRole extends Construct {
initialPolicy: [
new cdk.aws_iam.PolicyStatement({
effect: cdk.aws_iam.Effect.ALLOW,
actions: ['iam:CreateServiceLinkedRole', 'iam:GetRole'],
actions: ['iam:CreateServiceLinkedRole', 'iam:GetRole', 'lambda:GetFunction'],
resources: ['*'],
}),
],
Expand Down
1 change: 1 addition & 0 deletions ...rator/constructs/test/aws-autoscaling/__snapshots__/create-autoscaling-group.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,7 @@ exports[`AutoscalingGroup Construct(AutoscalingGroup): Snapshot Test 1`] = `
"Action": [
"iam:CreateServiceLinkedRole",
"iam:GetRole",
"lambda:GetFunction",
],
"Effect": "Allow",
"Resource": "*",
Expand Down
1 change: 1 addition & 0 deletions ...packages/@aws-accelerator/constructs/test/aws-ec2/__snapshots__/firewall-asg.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,7 @@ exports[`LaunchTemplate Construct(FirewallAutoScalingGroup): Snapshot Test 1`]
"Action": [
"iam:CreateServiceLinkedRole",
"iam:GetRole",
"lambda:GetFunction",
],
"Effect": "Allow",
"Resource": "*",
Expand Down
1 change: 1 addition & 0 deletions ...s/@aws-accelerator/constructs/test/aws-iam/__snapshots__/service-linked-role.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,7 @@ exports[`ServiceLinkedRole Construct(ServiceLinkedRole): Snapshot Test 1`] = `
"Action": [
"iam:CreateServiceLinkedRole",
"iam:GetRole",
"lambda:GetFunction",
],
"Effect": "Allow",
"Resource": "*",
Expand Down
Loading