-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(config): remove deprecated field #658
Conversation
richardkeit
commented
Nov 25, 2024
•
edited
Loading
edited
- Running the installer process, this field is no longer required
- Silent error (without debug option) is hard to diagnose (given default behaviour in Cloudformation template from the workshop doesn't expose the entry point)

Currently the default DNS naming convention for Route 53 hosted zones of VPC endpoints is using sagemaker.api.{region}.amazonaws.com which is not the correct DNS for it as can be found in Endpoints & Quotas page https://docs.aws.amazon.com/general/latest/gr/sagemaker.html This is also the case for sagemaker runtime as well.
…le dashes for vpc lookups
Hi @richardkeit thank you for the PR! We merged your changes! |
Hi @richardkeit thank you for pointing this out. I can assure you this was not intentional. Sorry for this! |
I apologize for the authorship confusion. The issue occurred when I cherry-picked and squashed commits from your branch during the merge process, which inadvertently changed the commit attribution to my name. |