Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): remove deprecated field #658

Closed
wants to merge 18 commits into from

Conversation

richardkeit
Copy link
Contributor

@richardkeit richardkeit commented Nov 25, 2024

  • Running the installer process, this field is no longer required
| 1732510628170 | $ /landing-zone-accelerator-on-aws/source/packages/@aws-accelerator/tools/node_modules/.bin/ts-node --transpile-only uninstaller.ts --installer-stack-name AWSAccelerator-InstallerStack --ignore-termination-protection true --full-destroy true --partition --debug --delete-data --ignore-termination-protection --delete-bootstraps true --delete-pipelines                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        |
| 1732510628170 | (node:26906) [DEP0128] DeprecationWarning: Invalid 'main' field in '/landing-zone-accelerator-on-aws/source/node_modules/@aws-accelerator/config/package.json' of 'dist/index.js'. Please either fix that or report it to the module author                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            |
  • Silent error (without debug option) is hard to diagnose (given default behaviour in Cloudformation template from the workshop doesn't expose the entry point)
image

@fdjahnke
Copy link
Contributor

Hi @richardkeit thank you for the PR! We merged your changes!
They should be part of our next major release.
I will close this PR for now.

@fdjahnke fdjahnke closed this Jan 23, 2025
@richardkeit
Copy link
Contributor Author

Hi @fdjahnke , @erwaxler ,

How come I have lost the contribution recognition with these?

My commits:

What has been committed to the release:

@fdjahnke
Copy link
Contributor

Hi @richardkeit thank you for pointing this out. I can assure you this was not intentional. Sorry for this!
Not sure yet what happened. Let me investigate a bit and get you an update.

@fdjahnke
Copy link
Contributor

I apologize for the authorship confusion. The issue occurred when I cherry-picked and squashed commits from your branch during the merge process, which inadvertently changed the commit attribution to my name.
We're implementing measures to prevent similar attribution issues in future merges.
We will update the authorship with the next v1.12.0 update.
Thank you for bringing this to our attention.

@richardkeit richardkeit deleted the fix/uninstall branch February 20, 2025 23:23
@richardkeit
Copy link
Contributor Author

Hi @fdjahnke ,

Not a problem; it was just something I wanted clarified.
Also, it's worth mentioning that having the by @<github_handle> (like v1.8.0) in the release notes is a nice piece of recognition for those contributing to this solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants