[uniffi] Use Python 3.9 type hints in tests #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgeisler
commented
Mar 8, 2024
mulmarta
force-pushed
the
uniffi-python-type-hints
branch
from
9360bb4 to
a0a6e36
Compare
tomleavy
previously approved these changes
Mar 8, 2024
mgeisler
force-pushed
the
uniffi-python-type-hints
branch
from
a0a6e36 to
5a65a91
Compare
I believe this is the recommended way for modern Python code. Since this only affects the tests, I hope it’s okay to require a recent Python. This also fixes a few signatures in PythonGroupStateStorage to use the same signature as in the parent class.
mgeisler
force-pushed
the
uniffi-python-type-hints
branch
from
5a65a91 to
139ece3
Compare
tomleavy
approved these changes
Mar 11, 2024
mulmarta
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses #81
Description of changes:
I believe this is the recommended way for modern Python code. Since this only affects the tests, I hope it’s okay to use.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.