Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[uniffi] Make docstrings consistent #119

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

mgeisler
Copy link
Contributor

Issues:

Addresses #81.

Description of changes:

The “light-weight” descriptions are a left-over from when the library was called mls-lite and seen as a light-weight wrapper around mls-rs. The mls-rs-uniffi library is now more focused on being a FFI layer.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.

@mgeisler mgeisler requested a review from a team as a code owner March 18, 2024 13:54
The “light-weight” descriptions are a left-over from when the library
was called mls-lite and seen as a light-weight wrapper around mls-rs.
The mls-rs-uniffi library is now more focused on being a FFI layer.
@mgeisler mgeisler force-pushed the uniffi-docstrings branch from f3634c3 to 852cb5d Compare March 18, 2024 13:55
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.34%. Comparing base (650ed8d) to head (852cb5d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #119   +/-   ##
=======================================
  Coverage   89.34%   89.34%           
=======================================
  Files         173      173           
  Lines       31333    31333           
=======================================
  Hits        27993    27993           
  Misses       3340     3340           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomleavy tomleavy merged commit 15c5c35 into awslabs:main Mar 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants