Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[uniffi] Add ratchet_tree to join_group #122

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

mgeisler
Copy link
Contributor

Issues:

Addresses #81.

Description of changes:

Allow users to join a group using an exported ratchet tree.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.

@mgeisler mgeisler requested a review from a team as a code owner March 18, 2024 17:13
mulmarta
mulmarta previously approved these changes Mar 19, 2024
@mulmarta
Copy link
Contributor

Has conflicts now @mgeisler

@mgeisler mgeisler force-pushed the uniffi-join-ratchet-tree branch from 585d13e to 8512215 Compare March 19, 2024 17:46
@mgeisler
Copy link
Contributor Author

Has conflicts now @mgeisler

Thanks, I rebased it again and resolved them.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 93.22034% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 89.50%. Comparing base (81b190d) to head (8512215).

Files Patch % Lines
mls-rs-uniffi/src/lib.rs 92.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
+ Coverage   89.44%   89.50%   +0.06%     
==========================================
  Files         173      173              
  Lines       31363    31412      +49     
==========================================
+ Hits        28053    28116      +63     
+ Misses       3310     3296      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomleavy tomleavy merged commit e4009f9 into awslabs:main Mar 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants