[uniffi] Remove GroupState type from storage trait
#128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the `GroupState` type from the `GroupStateStorage` trait in mls-rs-uniffi. This is done for two reasons: - It makes all methods on the trait consistent in the way that they take a `group_id` as the first argument. - Fewer types means less boiler-plate generated by the UniFFI bindings generator (`Vec<u8>` is a built-in type in UniFFI). The `EpochRecord` type stays: I don’t think we have a different way of passing in a vector of epochs IDs with their data. I could apply this change to mls-rs too, but it doesn’t seem useful there since it’s cheap and easy to create a new type in Rust.
|
I don't think this is super important for us, it was just something that came up when Anh was looking at the storage trait. |
mulmarta
approved these changes
Mar 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #128 +/- ##
==========================================
- Coverage 89.49% 89.49% -0.01%
==========================================
Files 173 173
Lines 31407 31404 -3
==========================================
- Hits 28109 28106 -3
Misses 3298 3298 ☔ View full report in Codecov by Sentry. |
tomleavy
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses #81
Description of changes:
This removes the
GroupStatetype from theGroupStateStoragetrait in mls-rs-uniffi. This is done for two reasons:It makes all methods on the trait consistent in the way that they take a
group_idas the first argument.Fewer types means less boiler-plate generated by the UniFFI bindings generator (
Vec<u8>is a built-in type in UniFFI).Call-outs:
The
EpochRecordtype stays: I don’t think we have a different way of passing in a vector of epochs IDs with their data.I could apply this change to mls-rs too, but it doesn’t seem useful there since it’s cheap and easy to create a new type in Rust.
Testing:
Updated tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.