Simplify Windows build steps into a single step #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commands depend on each other, so I think it’s clearer if they are put into a single step.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #136 +/- ##
=======================================
Coverage 89.51% 89.51%
=======================================
Files 173 173
Lines 31450 31450
=======================================
Hits 28151 28151
Misses 3299 3299 ☔ View full report in Codecov by Sentry. |
tomleavy
approved these changes
Apr 2, 2024
mulmarta
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The commands depend on each other, so I think it’s clearer if they are put into a single step.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.