Split jobs into dedicated sync and async jobs #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to cache the compilation artifacts per job, which should lead to faster builds.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
=======================================
Coverage 89.52% 89.52%
=======================================
Files 173 173
Lines 31450 31450
=======================================
Hits 28156 28156
Misses 3294 3294 ☔ View full report in Codecov by Sentry. |
tomleavy
approved these changes
Apr 3, 2024
|
Async build and test for sure is much faster now. Thanks! |
mulmarta
approved these changes
Apr 3, 2024
mgeisler
added a commit
to mgeisler/mls-rs
that referenced
this pull request
Apr 11, 2024
This is a followup to awslabs#137 to make the caching more consistent across the different CI jobs. I’ve noticed from other projects that it’s not very useful to cache the build artifacts for each branch: that just ends up polluting the 10 GB cache GitHub provides us with. So saving the cache is now disabled on non-main branches (the cache will still be read on all PRs from all branches).
mulmarta
pushed a commit
that referenced
this pull request
Apr 12, 2024
This is a followup to #137 to make the caching more consistent across the different CI jobs. I’ve noticed from other projects that it’s not very useful to cache the build artifacts for each branch: that just ends up polluting the 10 GB cache GitHub provides us with. So saving the cache is now disabled on non-main branches (the cache will still be read on all PRs from all branches).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This splits the
BuildAndTestjob into two: one for sync and one for async Rust. This allows us to cache the compilation artifacts per job, which should lead to faster builds. The caching is also implemented in this PR.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.