Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix receiving commit when pending commit #151

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Fix receiving commit when pending commit #151

merged 3 commits into from
Apr 23, 2024

Conversation

mulmarta
Copy link
Contributor

The test was failing due to "invalid confirmation tag". We may be processing someone else's commit while having the pending one.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.

@mulmarta mulmarta requested a review from a team as a code owner April 23, 2024 14:07
@mulmarta mulmarta changed the title Fix committing when pending commit Fix receiving commit when pending commit Apr 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.52%. Comparing base (1b1960d) to head (a12aebf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #151   +/-   ##
=======================================
  Coverage   89.51%   89.52%           
=======================================
  Files         173      173           
  Lines       31465    31484   +19     
=======================================
+ Hits        28166    28186   +20     
+ Misses       3299     3298    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

stefunctional
stefunctional previously approved these changes Apr 23, 2024
@tomleavy tomleavy merged commit c38cdef into main Apr 23, 2024
28 checks passed
@tomleavy tomleavy deleted the fixup branch April 23, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants