Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support receiving own proposals without an error #154

Merged
merged 8 commits into from
Jun 14, 2024
Merged

Conversation

mulmarta
Copy link
Contributor

@mulmarta mulmarta commented May 2, 2024

To make implementing DS's easier, this PR allows clients to receive their own proposals.

  • For plaintext proposals, this is trivial, since they can be processed the same way as proposals from other clients
  • For ciphertext proposals, we cache a list of hashes of all encrypted proposals we generated and just return Ok when processing one of them.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.

@mulmarta mulmarta requested a review from a team as a code owner May 2, 2024 11:21
stefunctional
stefunctional previously approved these changes May 3, 2024
Copy link
Contributor

@stefunctional stefunctional left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@codecov-commenter
Copy link

codecov-commenter commented May 17, 2024

Codecov Report

Attention: Patch coverage is 91.09589% with 13 lines in your changes missing coverage. Please review.

Project coverage is 89.65%. Comparing base (7c2926e) to head (5a24654).

Files Patch % Lines
mls-rs/src/group/message_hash.rs 57.14% 6 Missing ⚠️
mls-rs/src/group/mod.rs 94.20% 4 Missing ⚠️
mls-rs/src/group/message_processor.rs 86.36% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
+ Coverage   89.62%   89.65%   +0.02%     
==========================================
  Files         174      175       +1     
  Lines       31497    31578      +81     
==========================================
+ Hits        28230    28310      +80     
- Misses       3267     3268       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mulmarta and others added 4 commits June 12, 2024 21:30
Marta Mularczyk added 2 commits June 14, 2024 09:13
stefunctional
stefunctional previously approved these changes Jun 14, 2024
stefunctional
stefunctional previously approved these changes Jun 14, 2024
@tomleavy tomleavy merged commit 9b55525 into main Jun 14, 2024
30 of 31 checks passed
@tomleavy tomleavy deleted the own-proposal branch June 14, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants