Simplify map conditional compilation #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
==========================================
+ Coverage 89.53% 89.63% +0.09%
==========================================
Files 173 174 +1
Lines 31505 31507 +2
==========================================
+ Hits 28209 28240 +31
+ Misses 3296 3267 -29 ☔ View full report in Codecov by Sentry. |
tomleavy
previously approved these changes
Jun 11, 2024
stefunctional
previously approved these changes
Jun 11, 2024
mulmarta
commented
Jun 12, 2024
Co-authored-by: Stephane Raux <94983192+stefunctional@users.noreply.github.com>
stefunctional
previously approved these changes
Jun 12, 2024
stefunctional
approved these changes
Jun 12, 2024
tomleavy
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes. The PR removes a bunch of conditional compilation flags related to deciding on the type of map that is used: HashMap, Vec or BTreeMap.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.