Expose the key_package on AddProposal #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jszczepanik
changed the title
stefunctional
approved these changes
Jun 20, 2024
tomleavy
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves #165
Description of changes:
This PR adds a public method
AddProposal::key_package, which will allow crate consumers to read theKeyPackageheld by the proposal.Testing:
Surrounding getter methods had no unit tests, thus I skipped writing them for this method, too. Please let me know if you'd like me to add a test.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.