Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add message description function from 1.x #255

Merged
merged 3 commits into from
Mar 7, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mls-rs/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "mls-rs"
version = "0.45.1"
version = "0.45.2"
edition = "2021"
description = "An implementation of Messaging Layer Security (RFC 9420)"
homepage = "https://github.com/awslabs/mls-rs"
Expand Down
86 changes: 85 additions & 1 deletion mls-rs/src/group/framing.rs
Original file line number Diff line number Diff line change
Expand Up @@ -342,6 +342,45 @@ impl From<&PrivateMessage> for PrivateContentAAD {
}
}

#[derive(Clone, Debug, PartialEq)]
pub enum MlsMessageDescription<'a> {
Welcome {
key_package_refs: Vec<&'a KeyPackageRef>,
cipher_suite: CipherSuite,
},
ProtocolMessage {
group_id: &'a [u8],
epoch_id: u64,
content_type: ContentType, // commit, proposal, or application
},
GroupInfo,
KeyPackage,
}

impl MlsMessage {
pub fn description(&self) -> MlsMessageDescription<'_> {
match &self.payload {
MlsMessagePayload::Welcome(w) => MlsMessageDescription::Welcome {
key_package_refs: w.secrets.iter().map(|s| &s.new_member).collect(),
cipher_suite: w.cipher_suite,
},
MlsMessagePayload::Plain(p) => MlsMessageDescription::ProtocolMessage {
group_id: &p.content.group_id,
epoch_id: p.content.epoch,
content_type: p.content.content_type(),
},
#[cfg(feature = "private_message")]
MlsMessagePayload::Cipher(c) => MlsMessageDescription::ProtocolMessage {
group_id: &c.group_id,
epoch_id: c.epoch,
content_type: c.content_type,
},
MlsMessagePayload::GroupInfo(_) => MlsMessageDescription::GroupInfo,
MlsMessagePayload::KeyPackage(_) => MlsMessageDescription::KeyPackage,
}
}
}

#[derive(Clone, Debug, PartialEq, MlsSize, MlsEncode, MlsDecode)]
#[cfg_attr(
all(feature = "ffi", not(test)),
Expand Down Expand Up @@ -675,15 +714,18 @@ pub(crate) mod test_utils {
#[cfg(feature = "private_message")]
#[cfg(test)]
mod tests {
use alloc::vec;
use assert_matches::assert_matches;

use crate::{
client::test_utils::{TEST_CIPHER_SUITE, TEST_PROTOCOL_VERSION},
crypto::test_utils::test_cipher_suite_provider,
group::{
framing::test_utils::get_test_ciphertext_content,
proposal_ref::test_utils::auth_content_from_proposal, RemoveProposal,
proposal_ref::test_utils::auth_content_from_proposal, test_utils::test_group,
RemoveProposal,
},
key_package::test_utils::test_key_package_message,
};

use super::*;
Expand Down Expand Up @@ -745,4 +787,46 @@ mod tests {

assert_eq!(computed_ref, expected_ref.to_vec());
}

#[maybe_async::test(not(mls_build_async), async(mls_build_async, crate::futures_test))]
async fn message_description() {
let mut group = test_group(TEST_PROTOCOL_VERSION, TEST_CIPHER_SUITE).await;

let message = group.commit(vec![]).await.unwrap();

let expected = MlsMessageDescription::ProtocolMessage {
group_id: group.group_id(),
epoch_id: group.context().epoch,
content_type: ContentType::Commit,
};

assert_eq!(message.commit_message.description(), expected);

group.apply_pending_commit().await.unwrap();

let message = group
.encrypt_application_message(b"123", vec![])
.await
.unwrap();

let expected = MlsMessageDescription::ProtocolMessage {
group_id: group.group_id(),
epoch_id: group.context().epoch,
content_type: ContentType::Application,
};

assert_eq!(message.description(), expected);

let group_info = group
.group_info_message_allowing_ext_commit(true)
.await
.unwrap();

assert_eq!(group_info.description(), MlsMessageDescription::GroupInfo);

let key_package =
test_key_package_message(TEST_PROTOCOL_VERSION, TEST_CIPHER_SUITE, "something").await;

assert_eq!(key_package.description(), MlsMessageDescription::KeyPackage);
}
}
2 changes: 1 addition & 1 deletion mls-rs/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ pub use mls_rs_core::extension::{Extension, ExtensionList};
pub use crate::{
client::Client,
group::{
framing::{MlsMessage, WireFormat},
framing::{MlsMessage, MlsMessageDescription, WireFormat},
mls_rules::MlsRules,
Group,
},
Expand Down
Loading