Fix unused proposals when receiving commit #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when receiving commit The test currently fails and the implementation will be fixed in the next commit.
Unused proposals were previously made of the proposals in the received commit that would cause the commit to be invalid and thus were excluded. But given that invalid proposals when receiving a commit cause the entire commit to be rejected, it means that unused proposals were always empty when receiving a commit. Unused proposals are now made of the proposals in the receiver's cache that are not in the received commit.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
==========================================
- Coverage 91.65% 91.63% -0.02%
==========================================
Files 169 169
Lines 30851 30916 +65
==========================================
+ Hits 28275 28330 +55
- Misses 2576 2586 +10 ☔ View full report in Codecov by Sentry. |
mulmarta
previously approved these changes
Jan 24, 2024
The previous term was confusing in the context of receiving a commit. This also removes outdated comments in tests from back when only unused proposals from the committer were returned.
mulmarta
approved these changes
Jan 24, 2024
tomleavy
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unused proposals were previously made of the proposals in the received
commit that would cause the commit to be invalid and thus were excluded.
But given that invalid proposals when receiving a commit cause the
entire commit to be rejected, it means that unused proposals were always
empty when receiving a commit.
Unused proposals are now made of the proposals in the receiver's cache
that are not in the received commit.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.