[uniffi] Improve async tests #92
Closed
+83
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The macro takes the names of one or two Python scripts inside the `test_bindings/` directory and uses them to construct unit tests. This saves a bit of boiler-plate code at the point where the test is created. It also allows us to quickly see if there are gaps in the test coverage between the sync and async code. This comes at the expense of more “magic” in the form of the macro. The consistency of no boiler-plate code might make this worth the cost.
Also add an async test for the `generate_signature_keypair` function.
mgeisler
force-pushed
the
more-async-tests
branch
from
4769def to
5492064
Compare
|
Superseded by #130. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses #81.
Description of changes:
This brings the async tests in sync with the sync tests and it rewrites them to use the
asynckeyword in Python.Call-outs:
This should be merged after #91 (or rebased away as needed).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT license.