Skip to content

Commit

Permalink
removing flake8 and isort, adding ruff to scripts
Browse files Browse the repository at this point in the history
  • Loading branch information
dgraeber committed May 21, 2024
1 parent 1284bc8 commit 78b9aa3
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 9 deletions.
6 changes: 3 additions & 3 deletions scripts/fix.sh
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@ cd ${DIR}/..
echo "Fixing: $(cd "$(dirname "$FIX_PATH")"; pwd)/$(basename "$FIX_PATH"), Language: ${LANGUAGE}"

if [[ $LANGUAGE == "python" ]]; then
echo "Running isort, black"
isort ${FIX_PATH}
black ${FIX_PATH}
echo "Running ruff"
ruff format ${FIX_PATH}
ruff check --fix ${FIX_PATH}
elif [[ $LANGUAGE == "typescript" ]]; then
echo "Running prettier"
npx prettier --write ${FIX_PATH}
Expand Down
10 changes: 5 additions & 5 deletions scripts/validate.sh
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ echo "Validating: $(cd "$(dirname "$VALIDATE_PATH")"; pwd)/$(basename "$VALIDATE

echo "Validating Formatting"
if [[ $LANGUAGE == "python" ]]; then
echo "Checking isort, black"
isort --check ${VALIDATE_PATH}
black --check ${VALIDATE_PATH}
echo "Running ruff"
ruff format ${FIX_PATH}
ruff check --fix ${FIX_PATH}
elif [[ $LANGUAGE == "typescript" ]]; then
echo "Checking prettier"
npx prettier -c ${VALIDATE_PATH}
Expand All @@ -65,8 +65,8 @@ fi
if [[ $SKIP_STATIC_CHECKS == "false" ]]; then
echo "Validating Static Checks"
if [[ $LANGUAGE == "python" ]]; then
echo "Checking flake8, mypy"
flake8 ${VALIDATE_PATH}
echo "Checking mypy"
#flake8 ${VALIDATE_PATH}
mypy --ignore-missing-imports ${VALIDATE_PATH}
else
echo "ERROR Language: ${LANGUAGE}"
Expand Down
1 change: 0 additions & 1 deletion seedfarmer/mgmt/bundle_support.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@


class BundleS3Support:

codeseeder_bucket: Optional[str] = None
codeseeder_key: Optional[str] = None
seedfarmer_bucket: Optional[str] = None
Expand Down

0 comments on commit 78b9aa3

Please sign in to comment.