Adding Tags to SeedFarmer Roles #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgraeber
requested review from
kukushking,
malachi-constant,
LeonLuttenberger and
srinivasreddych
|
What is the ask behind adding seedfarmer version to Toolchain and deployment IAM roles? |
malachi-constant
approved these changes
May 16, 2024
kukushking
approved these changes
May 16, 2024
To add metadata to the role in case we want to check the version and make sure it is at the proper level for features...if not, throw an error / tell the end user to update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adding the seedfarmer version to the tags of the toolchain role and deployment role for lookup later on
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.