Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Amazon Linux codebuild images to image override with opinionated runtimes #720

Closed
wants to merge 2 commits into from
Closed

add Amazon Linux codebuild images to image override with opinionated runtimes #720

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6605ab
add Amazon Linux codebuild images to image override with opinionated …
cnfait Sep 10, 2024
135c6dd
CodeBuild-provided runtimes: loop over Enum __members__ to include al…
cnfait Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ This project adheres to [Semantic Versioning](http://semver.org/) and [Keep a Ch
## Unreleased

### New
- add AWS-curated Amazon Linux codebuild images to image override with opinionated runtimes

### Changes

Expand Down
6 changes: 6 additions & 0 deletions docs/source/manifests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,12 @@ There are multiple [build images and available runtimes](https://docs.aws.amazon
|aws/codebuild/standard:7.0|nodejs:18|
||python:3.11|
||java:corretto21|
|aws/codebuild/amazonlinux2-x86_64-standard:4.0|nodejs:16|
||python:3.9|
||java:corretto17|
|aws/codebuild/amazonlinux2-x86_64-standard:5.0|nodejs:18|
||python:3.11|
||java:corretto21|

#### Custom Build Images
If an end user wants to build their own image, it is STRONGLY encouraged to use [this Dockerfile from AWS public repos](https://github.com/awslabs/aws-codeseeder/blob/main/images/code-build-image/Dockerfile) as the base layer. `seed-farmer` leverages this as the base for its default image ([see HERE](https://github.com/awslabs/aws-codeseeder/blob/main/images/code-build-image/Dockerfile)). It is up to the module developer to verify all proper libraries are installed and available.
Expand Down
4 changes: 4 additions & 0 deletions seedfarmer/commands/_runtimes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,14 @@ class CuratedBuildImages:
class ImageEnums(Enum):
UBUNTU_STANDARD_6 = "aws/codebuild/standard:6.0"
UBUNTU_STANDARD_7 = "aws/codebuild/standard:7.0"
AL2_STANDARD_4 = "aws/codebuild/amazonlinux2-x86_64-standard:4.0"
AL2_STANDARD_5 = "aws/codebuild/amazonlinux2-x86_64-standard:5.0"

class ImageRuntimes(Enum):
UBUNTU_STANDARD_6 = {"nodejs": "16", "python": "3.10", "java": "corretto17"}
UBUNTU_STANDARD_7 = {"nodejs": "18", "python": "3.11", "java": "corretto21"}
AL2_STANDARD_4 = {"nodejs": "16", "python": "3.9", "java": "corretto17"}
AL2_STANDARD_5 = {"nodejs": "18", "python": "3.11", "java": "corretto21"}


def get_runtimes(codebuild_image: Optional[str]) -> Optional[Dict[str, str]]:
Expand Down