Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename keyword partial to nonterminating #1323

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Rename keyword partial to nonterminating #1323

merged 2 commits into from
Feb 13, 2025

Conversation

ice1000
Copy link
Member

@ice1000 ice1000 commented Feb 13, 2025

As title

@ice1000 ice1000 added this to the v0.38 milestone Feb 13, 2025
@ice1000 ice1000 marked this pull request as ready for review February 13, 2025 21:54
@ice1000 ice1000 enabled auto-merge February 13, 2025 21:54
@ice1000 ice1000 merged commit 4ba4c80 into main Feb 13, 2025
4 checks passed
@ice1000 ice1000 deleted the partial-element branch February 13, 2025 21:55
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.63%. Comparing base (88913ad) to head (557e988).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...se/src/main/java/org/aya/normalize/Normalizer.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1323      +/-   ##
============================================
- Coverage     83.63%   83.63%   -0.01%     
  Complexity     4168     4168              
============================================
  Files           375      375              
  Lines         12062    12060       -2     
  Branches       1425     1425              
============================================
- Hits          10088    10086       -2     
  Misses         1217     1217              
  Partials        757      757              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mio-19
Copy link
Contributor

mio-19 commented Feb 14, 2025

This keyword is so long

@ice1000
Copy link
Member Author

ice1000 commented Feb 14, 2025

This keyword is so long

True. It's shorter than the Agda equivalent though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants