Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: prepare introduction of package scopes #248

Merged
merged 9 commits into from
Nov 28, 2024
Merged

core: prepare introduction of package scopes #248

merged 9 commits into from
Nov 28, 2024

Conversation

serkonda7
Copy link
Member

@serkonda7 serkonda7 commented Nov 23, 2024 •
edited
Loading

For details regarding the design please look at #246 (regularly updated).

Part of #246

@serkonda7
gen.x: rename x_name to x_esc
041ffb8 
- add new `x_name` that will not prefix reserved keywords anymore
StunxFS
StunxFS reviewed Nov 26, 2024
View reviewed changes
StunxFS
StunxFS reviewed Nov 26, 2024
View reviewed changes
@serkonda7 serkonda7 changed the title core: rework scope system core: split global_scope into package scopes Nov 26, 2024
@serkonda7 serkonda7 changed the title core: split global_scope into package scopes core: prepare introduction of package scopes Nov 28, 2024
@serkonda7 serkonda7 marked this pull request as ready for review November 28, 2024 13:25
@serkonda7 serkonda7 merged commit 6b174a2 into bait-lang:main Nov 28, 2024
0 of 3 checks passed
@serkonda7 serkonda7 deleted the scope branch November 28, 2024 13:27
@serkonda7
Copy link
Member Author

@StunxFS wow, you are fast!
But I am aware, it's a change breaking the bootstrap process. The "fix" is merged in #250.
It's a little ugly in terms of development workflow but now I can continue with replacing the global scope.

@serkonda7 serkonda7 mentioned this pull request Nov 28, 2024
Open
@StunxFS
Copy link
Contributor

StunxFS commented Nov 28, 2024

And I deleted the comment because the PR had already been merged XD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StunxFS StunxFS StunxFS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serkonda7 @StunxFS