Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): add service values #290

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Conversation

oliverbaehler
Copy link
Contributor

Ciao Marc

Sorry I wasn't able to update the helm-docs locally:

go: downloading github.com/coreos/go-semver v0.3.0
sed: 1: "./chart/Chart.yaml": invalid command code .
sed: 1: "./chart/Chart.yaml": invalid command code .
make: *** [update-chart-version] Error 1

might be darwin related

@bakito
Copy link
Owner

bakito commented Jan 28, 2025

@oliverbaehler Thank you for the PR

Does the make helm-docs work if you remove the update-chart-version in the Makefile?

helm-docs: tb.helm-docs update-chart-version

-->

helm-docs: tb.helm-docs

@bakito
Copy link
Owner

bakito commented Jan 28, 2025

@oliverbaehler

Please rebase and run make helm-docs` again. The darwin issue could be fixed.

Signed-off-by: Oliver Bähler <oliverbaehler@hotmail.com>
@oliverbaehler
Copy link
Contributor Author

@bakito 🫡

@bakito bakito merged commit acce398 into bakito:main Jan 29, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants