Skip to content

Commit

Permalink
Fix errors with balena-engine update
Browse files Browse the repository at this point in the history
Many uses of `balena-engine update` were failing, including a bunch of
integration tests. The reason is explained below.

The new version of runc we are using changed the way it handles
command-line arguments -- particularly, how one needs to pass `-` to
mean "read the desired container configuration from the standard input".
So, the Engine code was still invoking `runc` using the old syntax,
which caused `runc` to fail.

This commit just updates the `go-runc` dependency, which is the layer we
use to invoke `runc` from Go. This new `go-runc` version contains an
update to use the new syntax.

Signed-off-by: Leandro Motta Barros <leandro@balena.io>
Change-type: patch
  • Loading branch information
lmbarros committed Nov 22, 2022
1 parent c715c6f commit 3b4f18c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion vendor.conf
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ github.com/containerd/fifo 650e8a8a179d040123db61f016cb
github.com/containerd/continuity 092b2c8f580622aee465fd5d6aba1dc8fad58b56 # v0.2.2
github.com/containerd/cgroups 1df78138f1e1e6ee593db155c6b369466f577651 # v1.0.3
github.com/containerd/console b5cb846c9186d67bcae3ce3c324e47cd317d9527 # v1.0.3
github.com/containerd/go-runc 16b287bc67d069a60fa48db15f330b790b74365b
github.com/containerd/go-runc 0fe8e6011112dff316f9dc1649290d92fcbb02a7
github.com/containerd/typeurl 5e43fb8b75ed2f2305fc04e6918c8d10636771bc # v1.0.2
github.com/containerd/ttrpc 0247db16a1f98bb76731a12ad72b8d49705b38b3 # v1.1.0
github.com/gogo/googleapis 01e0f9cca9b92166042241267ee2a5cdf5cff46c # v1.3.2
Expand Down
2 changes: 1 addition & 1 deletion vendor/github.com/containerd/go-runc/runc.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 3b4f18c

Please sign in to comment.