Skip to content

Commit

Permalink
Disable new tests that depend on swarm and plugins
Browse files Browse the repository at this point in the history
This is just disabling integration tests that rely on features we do not
support. We did this previously (see
088d3ee),
here we just doing the same thing for test cases introduced since then.

Signed-off-by: Leandro Motta Barros <leandro@balena.io>
Change-type: patch
  • Loading branch information
lmbarros committed Nov 3, 2022
1 parent c1247bd commit a987347
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 0 deletions.
6 changes: 6 additions & 0 deletions integration/plugin/common/plugin_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ func TestPluginInvalidJSON(t *testing.T) {
}

func TestPluginInstall(t *testing.T) {
t.Skip("plugins aren't supported")

skip.If(t, testEnv.IsRemoteDaemon, "cannot run daemon when remote daemon")
skip.If(t, testEnv.OSType == "windows")
skip.If(t, testEnv.IsRootless, "rootless mode has different view of localhost")
Expand Down Expand Up @@ -169,6 +171,8 @@ func TestPluginInstall(t *testing.T) {
}

func TestPluginsWithRuntimes(t *testing.T) {
t.Skip("plugins aren't supported")

skip.If(t, testEnv.IsRemoteDaemon, "cannot run daemon when remote daemon")
skip.If(t, testEnv.IsRootless, "Test not supported on rootless due to buggy daemon setup in rootless mode due to daemon restart")
skip.If(t, testEnv.OSType == "windows")
Expand Down Expand Up @@ -232,6 +236,8 @@ func TestPluginsWithRuntimes(t *testing.T) {
}

func TestPluginBackCompatMediaTypes(t *testing.T) {
t.Skip("plugins aren't supported")

skip.If(t, testEnv.IsRemoteDaemon, "cannot run daemon when remote daemon")
skip.If(t, testEnv.OSType == "windows")
skip.If(t, testEnv.IsRootless, "Rootless has a different view of localhost (needed for test registry access)")
Expand Down
2 changes: 2 additions & 0 deletions integration/plugin/logging/read_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ import (

// TestReadPluginNoRead tests that reads are supported even if the plugin isn't capable.
func TestReadPluginNoRead(t *testing.T) {
t.Skip("plugins aren't supported")

if runtime.GOOS == "windows" {
t.Skip("no unix domain sockets on Windows")
}
Expand Down
2 changes: 2 additions & 0 deletions integration/service/create_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -481,6 +481,8 @@ func TestCreateServiceSysctls(t *testing.T) {
// capabilities option with the correct value, we can assume that the capabilities has been
// plumbed correctly.
func TestCreateServiceCapabilities(t *testing.T) {
t.Skip("swarm isn't supported")

skip.If(
t, versions.LessThan(testEnv.DaemonAPIVersion(), "1.41"),
"setting service capabilities is unsupported before api v1.41",
Expand Down
6 changes: 6 additions & 0 deletions integration/service/jobs_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ import (
// TestCreateJob tests that a Service can be created and run with
// mode ReplicatedJob
func TestCreateJob(t *testing.T) {
t.Skip("swarm isn't supported")

skip.If(t, testEnv.IsRemoteDaemon)
skip.If(t, testEnv.DaemonInfo.OSType == "windows")

Expand All @@ -42,6 +44,8 @@ func TestCreateJob(t *testing.T) {
// TestReplicatedJob tests that running a replicated job starts the requisite
// number of tasks,
func TestReplicatedJob(t *testing.T) {
t.Skip("swarm isn't supported")

skip.If(t, testEnv.IsRemoteDaemon)
skip.If(t, testEnv.DaemonInfo.OSType == "windows")

Expand Down Expand Up @@ -86,6 +90,8 @@ func TestReplicatedJob(t *testing.T) {
// TestUpdateJob tests that a job can be updated, and that it runs with the
// correct parameters.
func TestUpdateReplicatedJob(t *testing.T) {
t.Skip("swarm isn't supported")

skip.If(t, testEnv.IsRemoteDaemon)
skip.If(t, testEnv.DaemonInfo.OSType == "windows")

Expand Down
4 changes: 4 additions & 0 deletions integration/system/info_linux_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ func TestInfoAPIVersioned(t *testing.T) {
// TestInfoDiscoveryBackend verifies that a daemon run with `--cluster-advertise` and
// `--cluster-store` properly returns the backend's endpoint in info output.
func TestInfoDiscoveryBackend(t *testing.T) {
t.Skip("consul isn't supported")

skip.If(t, testEnv.IsRemoteDaemon, "cannot run daemon when remote daemon")

const (
Expand Down Expand Up @@ -92,6 +94,8 @@ func TestInfoDiscoveryInvalidAdvertise(t *testing.T) {
// TestInfoDiscoveryAdvertiseInterfaceName verifies that a daemon run with `--cluster-advertise`
// configured with interface name properly show the advertise ip-address in info output.
func TestInfoDiscoveryAdvertiseInterfaceName(t *testing.T) {
t.Skip("consul isn't supported")

skip.If(t, testEnv.IsRemoteDaemon, "cannot run daemon when remote daemon")
skip.If(t, testEnv.IsRootless, "rootless mode has different view of network")
// TODO should we check for networking availability (integration-cli suite checks for networking through `Network()`)
Expand Down

0 comments on commit a987347

Please sign in to comment.