Popover fix - from using in real apps (#391)

baoagency · Mar 18, 2024 · 32787c7 · 32787c7
1 parent 98a6103
commit 32787c7
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/app/assets/stylesheets/polaris_view_components.css b/app/assets/stylesheets/polaris_view_components.css
diff --git a/app/assets/stylesheets/polaris_view_components/custom.pcss b/app/assets/stylesheets/polaris_view_components/custom.pcss
@@ -77,9 +77,10 @@ html[class~="Polaris-Summer-Editions-2023"] {
 }
 
 /* Filters */
-
 .Polaris-LegacyFilters-ConnectedFilterControl__RightContainer {
   .Polaris-LegacyFilters-ConnectedFilterControl__Item {
+    z-index: auto;
+
     & > div > div > button {
       margin-right: -1px;
       border-radius: 0;

diff --git a/app/components/polaris/filters_component.rb b/app/components/polaris/filters_component.rb
@@ -77,7 +77,7 @@ def popover_arguments
           style: ("width: #{@width}" if @width.present?),
           position: :below,
           alignment: :left,
-          append_to_body: true
+          append_to_body: false
         }
       end
 

diff --git a/test/components/polaris/filters_component_test.rb b/test/components/polaris/filters_component_test.rb
@@ -26,9 +26,9 @@ def test_default_filters
             assert_selector "[data-polaris-popover-target='activator']" do
               assert_selector ".Polaris-Button", text: "Filter"
             end
+            assert_selector "[data-polaris-popover-target='popover']", text: "Content"
           end
         end
-        assert_selector "[data-polaris-popover-target='template']", visible: :hidden
       end
     end
   end