Merge pull request #377 from baoagency/filters

Fix filter popovers
baoagency · Feb 10, 2024 · 45a397c · 45a397c
2 parents b153d40 + bf51544
commit 45a397c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/app/components/polaris/filters_component.rb b/app/components/polaris/filters_component.rb
@@ -76,7 +76,8 @@ def popover_arguments
           sectioned: @sectioned,
           style: ("width: #{@width}" if @width.present?),
           position: :below,
-          alignment: :left
+          alignment: :left,
+          append_to_body: true
         }
       end
 

diff --git a/test/components/polaris/filters_component_test.rb b/test/components/polaris/filters_component_test.rb
@@ -26,9 +26,9 @@ def test_default_filters
             assert_selector "[data-polaris-popover-target='activator']" do
               assert_selector ".Polaris-Button", text: "Filter"
             end
-            assert_selector "[data-polaris-popover-target='popover']", text: "Content"
           end
         end
+        assert_selector "[data-polaris-popover-target='template']", visible: :hidden
       end
     end
   end