Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover fix - from using in real apps #391

Merged
merged 3 commits into from
Mar 18, 2024
+7 −4
Merged

Popover fix - from using in real apps #391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6729293
Fix for filter popovers without using append_to_body (which breaks St…
forsbergplustwo Feb 26, 2024
3c3d2cc
Update main css file
forsbergplustwo Feb 26, 2024
e4379b2
Fix test filter_component
forsbergplustwo Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/assets/stylesheets/polaris_view_components.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion app/assets/stylesheets/polaris_view_components/custom.pcss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,10 @@ a.Polaris-Tag__Button {
}

/* Filters */

.Polaris-LegacyFilters-ConnectedFilterControl__RightContainer {
.Polaris-LegacyFilters-ConnectedFilterControl__Item {
z-index: auto;

& > div > div > button {
margin-right: -1px;
border-radius: 0;
Expand Down
2 changes: 1 addition & 1 deletion app/components/polaris/filters_component.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def popover_arguments
style: ("width: #{@width}" if @width.present?),
position: :below,
alignment: :left,
append_to_body: true
append_to_body: false
}
end

Expand Down
2 changes: 1 addition & 1 deletion test/components/polaris/filters_component_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ def test_default_filters
assert_selector "[data-polaris-popover-target='activator']" do
assert_selector ".Polaris-Button", text: "Filter"
end
assert_selector "[data-polaris-popover-target='popover']", text: "Content"
end
end
assert_selector "[data-polaris-popover-target='template']", visible: :hidden
end
end
end
Expand Down
Loading