New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: set radio button checked according to form field #445

Merged

kirillplatonov merged 1 commit into baoagency:main from k0va1:feature/fix_radio_button_checked_for_forms

Sep 9, 2024

Contributor

k0va1 commented Sep 9, 2024

No description provided.


          bugfix: set radio button checked according to form field

f292432

kirillplatonov merged commit 6a51583 into baoagency:main

4 checks passed

Contributor

hirowatari commented Oct 30, 2024

Previously this would set the radio button to whatever enabled was.

= render Polaris::ChoiceListComponent.new(form: f, attribute: :enabled, name: :enabled) do |choice|
  = choice.with_radio_button(label: 'Enable', value: true)
  = choice.with_radio_button(label: 'Disable', value: false)

Now checked must also be specified.

= render Polaris::ChoiceListComponent.new(form: f, attribute: :enabled, name: :enabled) do |choice|
  = choice.with_radio_button(label: 'Enable', value: true, checked: f.object.enabled?)
  = choice.with_radio_button(label: 'Disable', value: false, checked: !f.object.enabled?)

Is this intentional? I read through the code for a bit, but thought it would be better to just ask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet