[Chore] Composer 2 support #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't seem like it can be fully tested because of the When I do a composer update without the At the end of the day, I think this is fine. We don't really want to be testing out github workflows with dev releases (as we dont want false positive test failures) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 I think this should allow usage with composer 2. There isn't an official tag yet, so
^2.0@devshould suffice to allow dev stability versions of the release. Naturally once the official composer 2 release is made, we should update the dependency to be"composer/composer": "^1.6 || ^2.0",I have verified that our (ide-helper's) usage of composer is limited to
ClassMapGenerator::createMap, whose signature doesn't seem to have changed in composer 2.grumphpadded support for composer 2 in0.18.1, hence why I have updated it in this PR.Related: psalm/psalm-plugin-laravel#89