Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add onClick support to the ButtonWithLinkAndEventLogging component #1615

Closed
wants to merge 2 commits into from

Conversation

footballlstore
Copy link
Contributor

Description:
This pull request introduces the following changes to the ButtonWithLinkAndEventLogging component:

  • Updated the ButtonWithLinkAndEventLogProps type to support all props from ButtonWithLinkProps.
  • Added handling for the onClick prop, which is now invoked after event logging.
  • Included the onClick dependency in useCallback to ensure proper memoization.

These improvements:

  • Preserve the event logging functionality.
  • Enable additional actions to be performed via the onClick prop.
  • Ensure correct type definitions for the component.

Tests: ✅ All tests passed successfully.

Copy link

vercel bot commented Jan 26, 2025

@footballlstore is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jan 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 4:26pm

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 26, 2025

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@footballlstore
Copy link
Contributor Author

@brendan-defi @wbnns check this pr please

@brendan-defi
Copy link
Collaborator

Hi @footballlstore thanks for your submission. This component is specifically meant to handle links, so we do not want onClick behavior.

Our basic Button component does support onClick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants