Skip to content

Commit

Permalink
Bump version and update changelog
Browse files Browse the repository at this point in the history
  • Loading branch information
bash committed May 18, 2024
1 parent 329cc8c commit aded425
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 7 deletions.
2 changes: 1 addition & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ readme = "readme.md"
repository = "https://github.com/bash/terminal-colorsaurus"
categories = ["command-line-interface"]
license = "MIT OR Apache-2.0"
version = "0.4.0"
version = "0.4.1"
edition = "2021"
rust-version = "1.70.0"
exclude = [".github", ".gitignore", "*.sh", "benchmark/**/*"]
Expand Down
4 changes: 4 additions & 0 deletions changelog.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
# Changelog
## 0.4.1
* 🐛 Fixed `OSC 11` response being visible to users of GNU Screen
by detecting Screen and erroring before sending any control sequences. #16

## 0.4.0
* ⚡ Renamed «color scheme» to «color palette».
* ⚡ Removed `is_dark_on_light` and `is_light_on_dark` functions. Use `color_scheme` instead.
Expand Down
1 change: 1 addition & 0 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@
//! * linux
//! * Jetbrains Fleet
//! * iSH
//! * GNU Screen
//!
//! </details>
//!
Expand Down
10 changes: 5 additions & 5 deletions src/xterm/quirks.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,20 +15,20 @@ fn terminal_quirk_from_env_eager() -> TerminalQuirks {
// `TERM=dumb` indicates that the terminal supports very little features.
// We don't want to send any escape sequences to those terminals.
Ok(term) if term == "dumb" => Unsupported,
// Why is GNU screen unsupported?
// Why is GNU Screen unsupported?
//
// 1. screen only supports `OSC 11` (background) and not `OSC 10` (foreground)
// 1. Screen only supports `OSC 11` (background) and not `OSC 10` (foreground)
//
// 2. screen replies to queries in the incorrect order.
// 2. Screen replies to queries in the incorrect order.
// We send `OSC 11` + `DA1` and expect the answers to also be in that order.
// However, as far as I can tell, screen relays the `OSC 11` query to the underlying terminal,
// However, as far as I can tell, Screen relays the `OSC 11` query to the underlying terminal,
// and so we get the `DA1` response back *first*. This is usually an indicator that
// the terminal doesn't support the `OSC` query.
//
// There are two both equally broken workarounds:
//
// * Don't send `DA1`, just `OSC 11`. \
// Since screen forwards the query to the underlying terminal, we won't get an answer
// Since Screen forwards the query to the underlying terminal, we won't get an answer
// if the underlying terminal doesn't support it. And we don't have a way to detect that
// => we hit the 1s timeout :/
//
Expand Down

0 comments on commit aded425

Please sign in to comment.