fix: sync k6 dependencies and update #32
Open
+122
−842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takehaya
reviewed
Feb 4, 2025
| @@ -6,6 +6,8 @@ | |||
| pkill hss-server | |||
| ./out/bin/hss-server -network_type sctp >/dev/null 2>&1 & | |||
|
|
|||
| sleep 2 | |||
There was a problem hiding this comment.
Please tell me why you included this
There was a problem hiding this comment.
@takehaya
It is because run the test is faster than initializing the hss server.
Test execution sometimes fails.
https://github.com/bbsakura/xk6-diameter/actions/runs/13128052232/job/36628073507#step:7:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Updated several dependencies to their latest versions, including
go.k6.io/k6and various others.gojalibrary withgrafana/sobekAdded a new target
go-dep-syncto install and rungo-depsync --parent go.k6.io/k6for synchronizing Go module dependencies.Why
Dependency issues when building with latest xk6
Merge condition
Related issues