Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FORMS-1560 updated validation message for revising status recipient emails section #1581

Merged

Conversation

revanth-banala
Copy link
Collaborator

Description

When a user try to search another recipient email rather than default one and if it does not exist, wrong validation message shows up. Needs to modify the message to “No results found, Add team members on draft/submission manage page” instead of current message “No Form Reviewers found with the search, Add form reviewers on the manage page"
Acceptance Criteria

User can search recipient emails on recipient email section and if its not found, they should able to know where to add team members so that it should show up on search

Type of Change

fix (a bug fix)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have run the npm script lint on the frontend and backend
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have approval from the product owner for the contribution in this pull request

Further comments

@revanth-banala revanth-banala marked this pull request as ready for review January 17, 2025 22:34
Copy link
Collaborator

@jasonchung1871 jasonchung1871 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is technically complete, but do we require translations for all languages? This might be a question to raise in SCRUM.

@abhilash-aot
Copy link
Collaborator

abhilash-aot commented Jan 20, 2025

This is technically complete, but do we require translations for all languages? This might be a question to raise in SCRUM.

would be good to add it to all the transalation json files now itself so it doesnt need to be revisited again.

@revanth-banala
Copy link
Collaborator Author

I have made translations in all languages using google translate.

@revanth-banala revanth-banala merged commit b32e248 into bcgov:main Jan 28, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants